Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace got with node-fetch on functions-with-args.test.js #6245

Merged
merged 8 commits into from
Dec 15, 2023
Merged

refactor: replace got with node-fetch on functions-with-args.test.js #6245

merged 8 commits into from
Dec 15, 2023

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Dec 5, 2023

Summary

refactor: replace got with node-fetch on functions-with-args.test.js

related to #5695

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@hereje hereje requested a review from a team as a code owner December 5, 2023 19:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

📊 Benchmark results

Comparing with a5740db

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB (no change)
  • Number of ts-expect-error directives: 1,292 (no change)

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Dec 13, 2023
@khendrikse khendrikse changed the base branch from main to kh/refactor/replace-got/functions-with-args December 15, 2023 14:07
@khendrikse
Copy link
Contributor

Due to some GitHub actions working against this, currently merging this into another branch and trying to merge that new branch back into main (😓)

@khendrikse khendrikse merged commit 64f197e into netlify:kh/refactor/replace-got/functions-with-args Dec 15, 2023
32 checks passed
@khendrikse khendrikse mentioned this pull request Dec 15, 2023
Merged
5 tasks
@hereje hereje deleted the refactor/replace-got/functions-with-args.test.js branch December 15, 2023 14:18
kodiakhq bot added a commit that referenced this pull request Dec 18, 2023
@khendrikse @hereje
@kodiakhq @sarahetter
refactor: replace got with node-fetch on functions-with-args.test.js (#…
1d43172 
…6264)

* refactor: replace got with node-fetch on functions-with-args.test.js (#6245)

related to #5695

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* chore: empty commit to rerun actions

---------

Co-authored-by: Angel Mendez <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Sarah Etter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahetter sarahetter sarahetter approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hereje @khendrikse @sarahetter